update envoy to f40e279#1420
Conversation
| "@type": type.googleapis.com/envoy.config.metrics.v3.MetricsServiceConfig | ||
| transport_api_version: V3 | ||
| report_counters_as_deltas: true | ||
| emit_tags_as_labels: true |
library/common/config_template.cc
Outdated
| google_re2: {} | ||
| regex: '^vhost.api.vcluster\.[\w]+?\.upstream_rq_(?:[12345]xx|retry.*|time|timeout|total)' | ||
| use_all_default_tags: | ||
| true |
There was a problem hiding this comment.
as envoyproxy/envoy#16125 changes the behavior of metrics_sink, this is necessary to keep the metric names emitted by envoy the way it is, reference: https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/metrics/v3/stats.proto#envoy-v3-api-msg-config-metrics-v3-statsconfig,
There was a problem hiding this comment.
You want this to be false to preserve the existing stat names, this defaults to true
Signed-off-by: Jingwei Hao <jingwei.hao@gmail.com>
Signed-off-by: Jingwei Hao <jingwei.hao@gmail.com>
| - safe_regex: | ||
| google_re2: {} | ||
| regex: '^vhost.api.vcluster\.[\w]+?\.upstream_rq_(?:[12345]xx|retry.*|time|timeout|total)' | ||
| use_all_default_tags: |
There was a problem hiding this comment.
as envoyproxy/envoy#16125 changes the behavior of metrics_sink, this is necessary to keep the metric names emitted by envoy the way it is, doc is here: https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/metrics/v3/stats.proto#envoy-v3-api-msg-config-metrics-v3-statsconfig
somehow this comment is lost from the history ... :(
3 participants
Description: the primary goal is to pull this pr envoyproxy/envoy#16125, as it includes behavior of metrics_sink to send
tagsaslabelsof theMetricFamilyfield.Risk Level: medium
Testing: local build/ci
Signed-off-by: Jingwei Hao jingwei.hao@gmail.com